Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6015)

Unified Diff: chrome/renderer/webview_color_overlay.h

Issue 920843002: Move WebPageOverlay subclasses to use WebGraphicsContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/webview_color_overlay.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/webview_color_overlay.h
diff --git a/chrome/renderer/webview_color_overlay.h b/chrome/renderer/webview_color_overlay.h
index 3a2b9d1042e507f874350c40741f25b46d957acf..e195c4ddbfb5a592c69e509b7468bc72940cb9b9 100644
--- a/chrome/renderer/webview_color_overlay.h
+++ b/chrome/renderer/webview_color_overlay.h
@@ -7,7 +7,6 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
-#include "third_party/WebKit/public/platform/WebRect.h"
#include "third_party/WebKit/public/web/WebPageOverlay.h"
#include "third_party/skia/include/core/SkColor.h"
@@ -23,7 +22,8 @@ class WebViewColorOverlay : public blink::WebPageOverlay {
private:
// blink::WebPageOverlay implementation:
- virtual void paintPageOverlay(blink::WebCanvas* canvas);
+ virtual void paintPageOverlay(blink::WebGraphicsContext* context,
Lei Zhang 2015/02/12 20:01:21 might as do virtual -> override while we are here.
jbroman 2015/02/12 20:43:59 I've been advised in the past not to use "override
jbroman 2015/02/12 20:47:10 see e.g. https://codereview.chromium.org/679523004
+ const blink::WebSize& webViewSize);
content::RenderView* render_view_;
SkColor color_;
« no previous file with comments | « no previous file | chrome/renderer/webview_color_overlay.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698