Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 679523004: Remove overrides in BlinkPlatformImpl. (Closed)

Created:
6 years, 2 months ago by Peter Beverloo
Modified:
6 years, 1 month ago
Reviewers:
Mike West, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove overrides in BlinkPlatformImpl. We don't use override annotations for the Blink API. These seem to have sneaked in. BUG= Committed: https://crrev.com/0b7b27587319dbc86e363501eb83ea99f39f10df Cr-Commit-Position: refs/heads/master@{#301285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M content/child/blink_platform_impl.h View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Peter Beverloo
jam: PTAL (removing 11 overrides). mkwst: FYI
6 years, 2 months ago (2014-10-24 13:42:09 UTC) #2
Mike West
LGTM, thanks.
6 years, 2 months ago (2014-10-24 13:42:43 UTC) #3
jam
lgtm
6 years, 2 months ago (2014-10-24 23:40:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679523004/1
6 years, 1 month ago (2014-10-25 13:47:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/3127)
6 years, 1 month ago (2014-10-25 14:40:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679523004/1
6 years, 1 month ago (2014-10-25 15:40:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-25 16:09:46 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 16:10:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b7b27587319dbc86e363501eb83ea99f39f10df
Cr-Commit-Position: refs/heads/master@{#301285}

Powered by Google App Engine
This is Rietveld 408576698