Move WebPageOverlay subclasses to use WebGraphicsContext.

Move WebPageOverlay subclasses to use WebGraphicsContext.

To support Slimming Paint, page overlays are now expected to declare the size
of the content they draw to a canvas. This moves the two subclasses, both
solid-color overlays, to use the new interface.

Following this CL, the deprecated method will be removed on the Blink side.

BUG=450761
Committed: https://crrev.com/d8171ac22520b1d01577087435c4af9e8b3433dd
Cr-Commit-Position: refs/heads/master@{#316662}

[jbroman, 2015-02-12 16:44:57]

jbroman@chromium.org changed reviewers:
+ thestig@chromium.org, tommyw@chromium.org

[jbroman, 2015-02-12 16:44:58]

thestig for chrome/
tommyw for content/

This CL follows up after https://codereview.chromium.org/867063004/, and
precedes https://codereview.chromium.org/922713002/.

[Lei Zhang, 2015-02-12 20:01:22]

chrome/ lgtm

https://codereview.chromium.org/920843002/diff/1/chrome/renderer/webview_colo...
File chrome/renderer/webview_color_overlay.h (right):

https://codereview.chromium.org/920843002/diff/1/chrome/renderer/webview_colo...
chrome/renderer/webview_color_overlay.h:25: virtual void
paintPageOverlay(blink::WebGraphicsContext* context,
might as do virtual -> override while we are here.

[jbroman, 2015-02-12 20:43:59]

https://codereview.chromium.org/920843002/diff/1/chrome/renderer/webview_colo...
File chrome/renderer/webview_color_overlay.h (right):

https://codereview.chromium.org/920843002/diff/1/chrome/renderer/webview_colo...
chrome/renderer/webview_color_overlay.h:25: virtual void
paintPageOverlay(blink::WebGraphicsContext* context,
On 2015/02/12 20:01:21, Lei Zhang wrote:
> might as do virtual -> override while we are here.

I've been advised in the past not to use "override" on overrides crossing
library boundaries (the superclass here is in Blink) as it makes some cross-repo
changes painful.

[jbroman, 2015-02-12 20:47:10]

https://codereview.chromium.org/920843002/diff/1/chrome/renderer/webview_colo...
File chrome/renderer/webview_color_overlay.h (right):

https://codereview.chromium.org/920843002/diff/1/chrome/renderer/webview_colo...
chrome/renderer/webview_color_overlay.h:25: virtual void
paintPageOverlay(blink::WebGraphicsContext* context,
On 2015/02/12 20:43:59, jbroman wrote:
> On 2015/02/12 20:01:21, Lei Zhang wrote:
> > might as do virtual -> override while we are here.
> 
> I've been advised in the past not to use "override" on overrides crossing
> library boundaries (the superclass here is in Blink) as it makes some
cross-repo
> changes painful.

see e.g. https://codereview.chromium.org/679523004

[jbroman, 2015-02-17 15:33:29]

jbroman@chromium.org changed reviewers:
+ dpranke@chromium.org

[jbroman, 2015-02-17 15:33:30]

tommyw must be unavailable.

+dpranke for content/shell/renderer/test_runner/OWNERS

[Dirk Pranke, 2015-02-17 21:37:30]

lgtm

[jbroman, 2015-02-17 21:42:03]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2015-02-17 21:43:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/920843002/1

[commit-bot: I haz the power, 2015-02-17 21:47:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-17 21:47:59]

Patchset 1 (id:??) landed as
https://crrev.com/d8171ac22520b1d01577087435c4af9e8b3433dd
Cr-Commit-Position: refs/heads/master@{#316662}