Issue 920553002: Combine two validUnit calls

Issue 920553002: Combine two validUnit calls (Closed)

Created:
5 years, 10 months ago by rwlbuis

Modified:
5 years, 10 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Combine two validUnit calls It is less and more efficient code to just combine the flags and call validUnit once. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190374

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
M	LayoutTests/css3/calc/calc-numbers.html	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	LayoutTests/css3/calc/calc-numbers-expected.txt	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download

Total messages: 8 (2 generated)

Timothy Loh

On 2015/02/11 21:21:53, rwlbuis wrote: > PTAL, minor thing really. Can we test that calc(<number> ...

5 years, 10 months ago (2015-02-16 10:19:40 UTC) #3

rwlbuis

On 2015/02/16 10:19:40, Timothy Loh wrote: > On 2015/02/11 21:21:53, rwlbuis wrote: > > PTAL, ...

5 years, 10 months ago (2015-02-17 18:00:42 UTC) #4

Timothy Loh

On 2015/02/17 18:00:42, rwlbuis wrote: > On 2015/02/16 10:19:40, Timothy Loh wrote: > > On ...

5 years, 10 months ago (2015-02-17 23:37:16 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920553002/40001

5 years, 10 months ago (2015-02-17 23:38:24 UTC) #7

commit-bot: I haz the power

5 years, 10 months ago (2015-02-18 01:10:57 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190374