Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 920553002: Combine two validUnit calls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add test for calc Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/css3/calc/calc-numbers-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index ba9e52de3088d5eb98918313428c738a35e50915..ce3f4b5a9844fe9331cf8b5eae8189617ebd50aa 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -1016,11 +1016,8 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)
return true;
}
case CSSPropertyTabSize:
- // May be specified as a unit-less non-negative integer indicating number of space characters...
- validPrimitive = validUnit(value, FInteger | FNonNeg);
- // ... or as a Length.
- if (!validPrimitive)
- validPrimitive = validUnit(value, FLength | FNonNeg);
+ // May be specified as a unit-less non-negative integer or length indicating number of space characters.
+ validPrimitive = validUnit(value, FInteger | FLength | FNonNeg);
break;
case CSSPropertyBorderRadius:
case CSSPropertyWebkitBorderRadius:
« no previous file with comments | « LayoutTests/css3/calc/calc-numbers-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698