Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 920523003: Plumb WebTouchEvent::causesScrollingIfUncanceled to TouchEvent and (Closed)

Created:
5 years, 10 months ago by lazyboy
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, jdduke (slow)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Plumb WebTouchEvent::causesScrollingIfUncanceled to TouchEvent and PlatformTouchEvent. This will ensure that events that get re-routed from one renderer to another preserves this bit. Out of process renderers currenly re-route input events from one renderer process to another, and we need to preserve this bit for "touchmove"s to fire. BUG=454568 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M Source/core/events/TouchEvent.h View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/core/events/TouchEvent.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PlatformTouchEvent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
lazyboy
+Rick for review, this CL adds plumbing of a WebTouchEvent flag (causesScrollingIfUncanceled) to core/platform so ...
5 years, 10 months ago (2015-02-12 01:55:28 UTC) #2
Rick Byers
LGTM (sorry for the delay - travelling / flight issues) I'd really like to see ...
5 years, 10 months ago (2015-02-12 20:59:44 UTC) #4
lazyboy
schenney@ seems to be unresponsive, adding +aelias for Source/web/WebInputEventConversion.cpp +vollick for Source/platform/PlatformTouchEvent.h Thanks.
5 years, 10 months ago (2015-02-16 21:27:55 UTC) #6
aelias_OOO_until_Jul13
Source/web lgtm
5 years, 10 months ago (2015-02-17 21:20:26 UTC) #7
Ian Vollick
On 2015/02/17 21:20:26, aelias wrote: > Source/web lgtm Source/platform lgtm
5 years, 10 months ago (2015-02-17 21:31:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920523003/1
5 years, 10 months ago (2015-02-18 03:54:23 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 05:10:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190390

Powered by Google App Engine
This is Rietveld 408576698