[Telemetry] Reduce memory usage in presence of TraceValues

tools/telemetry/telemetry/results/page_test_results.py

Index: tools/telemetry/telemetry/results/page_test_results.py
diff --git a/tools/telemetry/telemetry/results/page_test_results.py b/tools/telemetry/telemetry/results/page_test_results.py
index 36866ecfdd9f465201124fb9a38871dc1eed643f..2a084fa2999f59358c9d775df886d07fb54c1e3a 100644
--- a/tools/telemetry/telemetry/results/page_test_results.py
+++ b/tools/telemetry/telemetry/results/page_test_results.py
@@ -127,6 +127,20 @@ class PageTestResults(object):
   def _GetStringFromExcInfo(self, err):
     return ''.join(traceback.format_exception(*err))
 
+  def CleanUp(self):
+    """Clean up any TraceValues contained within this results object."""
+    for run in self._all_page_runs:
+      for v in run.values:
+        if isinstance(v, trace.TraceValue):
+          v.CleanUp()
+          run.values.remove(v)

[nednguyen, 2015/02/18 18:35:59]

Why do you change this implementation?

[eakuefner, 2015/02/18 20:41:03]

all_page_specific_values is actually a @property that copies all values out of
each page run into a new list which it returns. To truly remove the values we
need to look at the page runs in this way.

+
+  def __enter__(self):
+    return self
+
+  def __exit__(self, _, __, ___):
+    self.CleanUp()
+
   def WillRunPage(self, page):
     assert not self._current_page_run, 'Did not call DidRunPage.'
     self._current_page_run = page_run.PageRun(page)