[Telemetry] Reduce memory usage in presence of TraceValues

tools/telemetry/telemetry/results/page_test_results.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import copy
 import datetime
 import itertools
 import logging
 import random
@@ skipping 109 matching lines @@
     return [v for v in values if isinstance(v, failure.FailureValue)]
 
   @property
   def skipped_values(self):
     values = self.all_page_specific_values
     return [v for v in values if isinstance(v, skip.SkipValue)]
 
   def _GetStringFromExcInfo(self, err):
     return ''.join(traceback.format_exception(*err))
 
+  def CleanUp(self):
+    """Clean up any TraceValues contained within this results object."""
+    for run in self._all_page_runs:
+      for v in run.values:
+        if isinstance(v, trace.TraceValue):
+          v.CleanUp()
+          run.values.remove(v)

[nednguyen, 2015/02/18 18:35:59]

Why do you change this implementation?

[eakuefner, 2015/02/18 20:41:03]

all_page_specific_values is actually a @property that copies all values out of
each page run into a new list which it returns. To truly remove the values we
need to look at the page runs in this way.

+
+  def __enter__(self):
+    return self
+
+  def __exit__(self, _, __, ___):
+    self.CleanUp()
+
   def WillRunPage(self, page):
     assert not self._current_page_run, 'Did not call DidRunPage.'
     self._current_page_run = page_run.PageRun(page)
     self._progress_reporter.WillRunPage(self)
 
   def DidRunPage(self, page, discard_run=False):  # pylint: disable=W0613
     """
     Args:
       page: The current page under test.
       discard_run: Whether to discard the entire run and all of its
@@ skipping 83 matching lines @@
         try:
           cloud_url = cloud_storage.Insert(
               bucket, remote_path, file_handle.GetAbsPath())
           sys.stderr.write(
               'View generated profiler files online at %s for page %s\n' %
               (cloud_url, page.display_name))
           self._pages_to_profiling_files_cloud_url[page].append(cloud_url)
         except cloud_storage.PermissionError as e:
           logging.error('Cannot upload profiling files to cloud storage due to '
                         ' permission error: %s' % e.message)