Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 920403002: Revert of bookmarks: Remove url_database.h entry from DEPS list. (Closed)

Created:
5 years, 10 months ago by kaliamoorthi
Modified:
5 years, 10 months ago
Reviewers:
tfarina, sdefresne, sky
CC:
browser-components-watch_chromium.org, chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bookmarks: Remove url_database.h entry from DEPS list. (patchset #2 id:20001 of https://codereview.chromium.org/912653005/) Reason for revert: Seem to cause a failure related to bookmark dependencies. Original issue's description: > bookmarks: Remove DEPS file now that componentization is almost done. > > Since the componentization of bookmarks is mostly done, we don't need the rules forbidding usage of //chrome/browser anymore, as the files still in > //chrome/browser/bookmarks won't be moved in the component (factories, > client, etc, all belongs to the embedder, not the component). > > BUG=383597 > TEST=checkdeps > R=sky@chromium.org,sdefresne@chromium.org > > Committed: https://crrev.com/de85300a1986e3ce43f89a56b08dbd5e2049c041 > Cr-Commit-Position: refs/heads/master@{#316201} TBR=sdefresne@chromium.org,sky@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=383597 Committed: https://crrev.com/38cc6c50282732ff5805681b96860742377148fb Cr-Commit-Position: refs/heads/master@{#316208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A chrome/browser/bookmarks/DEPS View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kaliamoorthi
Created Revert of bookmarks: Remove url_database.h entry from DEPS list.
5 years, 10 months ago (2015-02-13 12:50:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920403002/1
5 years, 10 months ago (2015-02-13 12:51:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 12:52:01 UTC) #3
blundell
On 2015/02/13 12:52:01, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) Could ...
5 years, 10 months ago (2015-02-13 12:52:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/38cc6c50282732ff5805681b96860742377148fb Cr-Commit-Position: refs/heads/master@{#316208}
5 years, 10 months ago (2015-02-13 12:52:47 UTC) #5
kaliamoorthi
5 years, 10 months ago (2015-02-13 12:55:22 UTC) #6
Message was sent while issue was closed.
On 2015/02/13 12:52:35, blundell wrote:
> On 2015/02/13 12:52:01, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1)
> 
> Could you provide a snippet illustrating the failure and a link to the failing
> bot? Thanks!

I see the below dependency failure 
ERROR in
/mnt/data/b/build/slave/Linux_Tests/build/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
  Illegal include: "chrome/utility/importer/bookmark_html_reader.h"
    Because of "-chrome" from chrome's include_rules.

in
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/2061...

This started happening after the CL landed.

Powered by Google App Engine
This is Rietveld 408576698