Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/browser/bookmarks/DEPS

Issue 920403002: Revert of bookmarks: Remove url_database.h entry from DEPS list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/DEPS
diff --git a/chrome/browser/bookmarks/DEPS b/chrome/browser/bookmarks/DEPS
new file mode 100644
index 0000000000000000000000000000000000000000..73aa9a2280da67545226d7fcca60a48ed4aebb81
--- /dev/null
+++ b/chrome/browser/bookmarks/DEPS
@@ -0,0 +1,43 @@
+include_rules = [
+ # Bookmarks is being made into a component (it will end up at
+ # //components/bookmarks and not depend on //chrome), so we have these basic
+ # rules followed by temporary exceptions. Please don't add to the list of
+ # exceptions!
+ "-chrome/browser",
+ "+chrome/browser/bookmarks",
+ "+chrome/browser/browser_process.h",
+ "+chrome/browser/favicon",
+ "+chrome/browser/chrome_notification_types.h",
+ "+chrome/browser/policy/profile_policy_connector.h",
+ "+chrome/browser/policy/profile_policy_connector_factory.h",
+ "+chrome/browser/profiles/incognito_helpers.h",
+ "+chrome/browser/profiles/profile.h",
+ "+chrome/browser/profiles/startup_task_runner_service.h",
+ "+chrome/browser/profiles/startup_task_runner_service_factory.h",
+ "+chrome/browser/signin/signin_manager_factory.h",
+ "+chrome/browser/undo/bookmark_undo_service.h",
+ "+chrome/browser/undo/bookmark_undo_service_factory.h",
+
+ # TODO(tfarina): Bring this list to zero. crbug.com/144783
+ # Do not add to the list of temporarily-allowed dependencies below,
+ # and please do not introduce more #includes of these files.
+ "!chrome/browser/history/history_service.h",
+ "!chrome/browser/history/history_service_factory.h",
+ "!chrome/browser/history/url_database.h",
+ # Do not add to the list of temporarily-allowed dependencies above,
+ # and please do not introduce more #includes of these files.
+]
+
+specific_include_rules = {
+ # For unit tests, it's fine to include utility process code.
+ '.*test\.cc': [
+ "+chrome/test/base/testing_profile.h",
+ "+chrome/utility/importer/bookmark_html_reader.h",
+ ],
+ # Allow to include flags_storage into enhanced_bookmarks_features.cc because
+ # it has a function used by about_flags.cc and it needs flags_storage.
+ # This should be removed after enhanced bookmarks experiment is over.
+ 'enhanced_bookmarks_features\.cc': [
+ "+chrome/browser/flags_storage.h",
+ ],
+}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698