Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 920243002: Mac: Fix omnibox hint text is 1px lower than typed text. (Closed)

Created:
5 years, 10 months ago by Andre
Modified:
5 years, 10 months ago
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@dragging-window-drawing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix omnibox hint text is 1px lower than typed text. The placeholder attributed string needs to have the same paragraph style attribute as the regular text. BUG=452632 Committed: https://crrev.com/019974b4ddd333b4781fd40214de4e1d54072e87 Cr-Commit-Position: refs/heads/master@{#316275}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 3 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Andre
shess@ please review. The diff is confusing, I basically moved the font and paragraph style ...
5 years, 10 months ago (2015-02-13 04:39:42 UTC) #3
Scott Hess - ex-Googler
lgtm I apologize for this code.
5 years, 10 months ago (2015-02-13 19:04:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920243002/20001
5 years, 10 months ago (2015-02-13 20:08:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-13 20:28:50 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:29:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/019974b4ddd333b4781fd40214de4e1d54072e87
Cr-Commit-Position: refs/heads/master@{#316275}

Powered by Google App Engine
This is Rietveld 408576698