chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h - Issue 920243002: Mac: Fix omnibox hint text is 1px lower than typed text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 920243002: Mac: Fix omnibox hint text is 1px lower than typed text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dragging-window-drawing

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

index 3fbe904ef2f58d4479126d1a5a3a4a1bfd17f0e4..174fee100e6b6f6e78599a32e554733e35a246f7 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

@@ -154,6 +154,9 @@ class OmniboxViewMac : public OmniboxView,

// though here we cannot really do the in-place operation they do.

void EmphasizeURLComponents() override;

+ // Apply our font and paragraph style to |as|.

+ void ApplyTextStyle(NSMutableAttributedString* as);

// Calculates text attributes according to |display_text| and applies them

// to the given |as| object.

void ApplyTextAttributes(const base::string16& display_text,

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm » ('j') | no next file with comments »