Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 920043003: Revert of Upstream Enhanced Bookmark Model (Closed)

Created:
5 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upstream Enhanced Bookmark Model (patchset #6 id:100001 of https://codereview.chromium.org/899403002/) Reason for revert: This is blocking downstream and people are complaining. I tried to land the downstream fix but there was a compile problem. Sorry, hope you can fix the problems and re-land. Original issue's description: > Upstream Enhanced Bookmark Model > > This is the data layout of enhanced bookmark. There is no reason why > this class should live in private repository. > > BUG=428832 > > Committed: https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261 > Cr-Commit-Position: refs/heads/master@{#315939} TBR=kkimlabs@chromium.org,newt@chromium.org,cjhopman@chromium.org,ianwen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428832 Committed: https://crrev.com/f40cb64710a333da6d554e98dfcc432cd6cf8f1f Cr-Commit-Position: refs/heads/master@{#315976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -722 lines) Patch
M build/get_landmines.py View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java View 1 chunk +326 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java View 1 chunk +0 lines, -326 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java View 1 chunk +0 lines, -391 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/enhanced_bookmarks/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
alex clarke (OOO till 29th)
Created Revert of Upstream Enhanced Bookmark Model
5 years, 10 months ago (2015-02-12 14:51:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920043003/1
5 years, 10 months ago (2015-02-12 14:52:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 14:52:48 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 14:53:40 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f40cb64710a333da6d554e98dfcc432cd6cf8f1f
Cr-Commit-Position: refs/heads/master@{#315976}

Powered by Google App Engine
This is Rietveld 408576698