Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Side by Side Diff: build/get_landmines.py

Issue 920043003: Revert of Upstream Enhanced Bookmark Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
(...skipping 11 matching lines...) Expand all
22 22
23 def print_landmines(): 23 def print_landmines():
24 """ 24 """
25 ALL LANDMINES ARE EMITTED FROM HERE. 25 ALL LANDMINES ARE EMITTED FROM HERE.
26 """ 26 """
27 if (distributor() == 'goma' and platform() == 'win32' and 27 if (distributor() == 'goma' and platform() == 'win32' and
28 builder() == 'ninja'): 28 builder() == 'ninja'):
29 print 'Need to clobber winja goma due to backend cwd cache fix.' 29 print 'Need to clobber winja goma due to backend cwd cache fix.'
30 if platform() == 'android': 30 if platform() == 'android':
31 print 'Clobber: to handle new way of suppressing findbugs failures.' 31 print 'Clobber: to handle new way of suppressing findbugs failures.'
32 print 'Clobber to fix gyp not rename package name (crbug.com/457038)'
33 if platform() == 'win' and builder() == 'ninja': 32 if platform() == 'win' and builder() == 'ninja':
34 print 'Compile on cc_unittests fails due to symbols removed in r185063.' 33 print 'Compile on cc_unittests fails due to symbols removed in r185063.'
35 if platform() == 'linux' and builder() == 'ninja': 34 if platform() == 'linux' and builder() == 'ninja':
36 print 'Builders switching from make to ninja will clobber on this.' 35 print 'Builders switching from make to ninja will clobber on this.'
37 if platform() == 'mac': 36 if platform() == 'mac':
38 print 'Switching from bundle to unbundled dylib (issue 14743002).' 37 print 'Switching from bundle to unbundled dylib (issue 14743002).'
39 if platform() in ('win', 'mac'): 38 if platform() in ('win', 'mac'):
40 print ('Improper dependency for create_nmf.py broke in r240802, ' 39 print ('Improper dependency for create_nmf.py broke in r240802, '
41 'fixed in r240860.') 40 'fixed in r240860.')
42 if (platform() == 'win' and builder() == 'ninja' and 41 if (platform() == 'win' and builder() == 'ninja' and
(...skipping 21 matching lines...) Expand all
64 print 'Clobber to fix GN not picking up increased ID range (crbug.com/444902)' 63 print 'Clobber to fix GN not picking up increased ID range (crbug.com/444902)'
65 64
66 65
67 def main(): 66 def main():
68 print_landmines() 67 print_landmines()
69 return 0 68 return 0
70 69
71 70
72 if __name__ == '__main__': 71 if __name__ == '__main__':
73 sys.exit(main()) 72 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698