Clear app banner data when history is cleared.

Clear app banner data when history is cleared.

This takes two forms. Firstly, When specific URLs are removed from the
browsing history, all historical banner data is removed for that URL.
Secondly, when browsing history is cleared, all app banner historical
data is cleared.

BUG=457407
Committed: https://crrev.com/38c69cc622197d934f6900b6a47976245841043e
Cr-Commit-Position: refs/heads/master@{#316416}

[benwells, 2015-02-12 11:15:37]

benwells@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2015-02-12 18:09:40]

lgtm

[benwells, 2015-02-12 22:16:11]

benwells@chromium.org changed reviewers:
+ bauerb@chromium.org

[benwells, 2015-02-12 22:17:09]

meant to say, +bauerb for owners of webui and browsing_data

[Bernhard Bauer, 2015-02-13 10:05:07]

LGTM with nits:

https://codereview.chromium.org/919843003/diff/1/chrome/browser/banners/app_b...
File chrome/browser/banners/app_banner_settings_helper.cc (right):

https://codereview.chromium.org/919843003/diff/1/chrome/browser/banners/app_b...
chrome/browser/banners/app_banner_settings_helper.cc:86: for (const auto&
origin_url : origin_urls) {
Using GURL instead of auto here is clearer, and not even more characters :)

https://codereview.chromium.org/919843003/diff/1/chrome/browser/ui/webui/hist...
File chrome/browser/ui/webui/history_ui.cc (right):

https://codereview.chromium.org/919843003/diff/1/chrome/browser/ui/webui/hist...
chrome/browser/ui/webui/history_ui.cc:675: for (const auto& expire_entry :
expire_list)
I would also consider using the actual type instead auto here.

[benwells, 2015-02-15 22:55:29]

New patchsets have been uploaded after l-g-t-m from
dfalcantara@chromium.org,bauerb@chromium.org

[benwells, 2015-02-15 22:56:05]

https://codereview.chromium.org/919843003/diff/1/chrome/browser/banners/app_b...
File chrome/browser/banners/app_banner_settings_helper.cc (right):

https://codereview.chromium.org/919843003/diff/1/chrome/browser/banners/app_b...
chrome/browser/banners/app_banner_settings_helper.cc:86: for (const auto&
origin_url : origin_urls) {
On 2015/02/13 10:05:06, Bernhard Bauer wrote:
> Using GURL instead of auto here is clearer, and not even more characters :)

Done.

https://codereview.chromium.org/919843003/diff/1/chrome/browser/ui/webui/hist...
File chrome/browser/ui/webui/history_ui.cc (right):

https://codereview.chromium.org/919843003/diff/1/chrome/browser/ui/webui/hist...
chrome/browser/ui/webui/history_ui.cc:675: for (const auto& expire_entry :
expire_list)
On 2015/02/13 10:05:06, Bernhard Bauer wrote:
> I would also consider using the actual type instead auto here.

Done.

[benwells, 2015-02-15 22:56:09]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-02-15 22:56:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/919843003/20001

[commit-bot: I haz the power, 2015-02-16 00:52:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-16 00:53:15]

Patchset 2 (id:??) landed as
https://crrev.com/38c69cc622197d934f6900b6a47976245841043e
Cr-Commit-Position: refs/heads/master@{#316416}