Clear app banner data when history is cleared.

chrome/browser/banners/app_banner_settings_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 
 #include <algorithm>
 #include <string>
 
 #include "chrome/browser/profiles/profile.h"
@@ skipping 61 matching lines @@
       app_dict = new base::DictionaryValue();
       origin_dict->SetWithoutPathExpansion(key_name, make_scoped_ptr(app_dict));
     }
   }
 
   return app_dict;
 }
 
 }  // namespace
 
+void AppBannerSettingsHelper::ClearHistoryForURLs(
+    Profile* profile,
+    const std::set<GURL>& origin_urls) {
+  HostContentSettingsMap* settings = profile->GetHostContentSettingsMap();
+  for (const auto& origin_url : origin_urls) {

[Bernhard Bauer, 2015/02/13 10:05:06]

Using GURL instead of auto here is clearer, and not even more characters :)

[benwells, 2015/02/15 22:56:05]

Done.

+    ContentSettingsPattern pattern(ContentSettingsPattern::FromURL(origin_url));
+    if (!pattern.IsValid())
+      continue;
+
+    settings->SetWebsiteSetting(pattern, ContentSettingsPattern::Wildcard(),
+                                CONTENT_SETTINGS_TYPE_APP_BANNER, std::string(),
+                                nullptr);
+  }
+}
+
 void AppBannerSettingsHelper::RecordBannerEvent(
     content::WebContents* web_contents,
     const GURL& origin_url,
     const std::string& package_name_or_start_url,
     AppBannerEvent event,
     base::Time time) {
   Profile* profile =
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
   if (profile->IsOffTheRecord() || web_contents->GetURL() != origin_url ||
       package_name_or_start_url.empty()) {
@@ skipping 229 matching lines @@
       GetAppDict(origin_dict.get(), package_name_or_start_url);
   if (!app_dict)
     return;
 
   // Update the setting and save it back.
   app_dict->SetBoolean(kHasBlockedKey, true);
   settings->SetWebsiteSetting(pattern, ContentSettingsPattern::Wildcard(),
                               CONTENT_SETTINGS_TYPE_APP_BANNER, std::string(),
                               origin_dict.release());
 }