Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 919683002: Remove canApplyCoverage from XP and all related functions in gpu code. (Closed)

Created:
5 years, 10 months ago by egdaniel
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@pdDstCopy
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove canApplyCoverage from XP and all related functions in gpu code. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0bdeec9640640922eb6b0a9f798bcd85eb898f29

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -87 lines) Patch
M include/gpu/GrXferProcessor.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M include/gpu/effects/GrCoverageSetOpXP.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 3 chunks +1 line, -15 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 3 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
egdaniel
Removes unneeded can apply coverage functions once the porter duff dst copy change lands.
5 years, 10 months ago (2015-02-11 15:11:29 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/919683002/diff/1/src/gpu/GrPipelineBuilder.h File src/gpu/GrPipelineBuilder.h (left): https://codereview.chromium.org/919683002/diff/1/src/gpu/GrPipelineBuilder.h#oldcode62 src/gpu/GrPipelineBuilder.h:62: bool canUseFracCoveragePrimProc(GrColor color, const GrDrawTargetCaps& caps) const; awww, ...
5 years, 10 months ago (2015-02-11 15:54:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919683002/20001
5 years, 10 months ago (2015-02-23 19:20:51 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:12:58 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0bdeec9640640922eb6b0a9f798bcd85eb898f29

Powered by Google App Engine
This is Rietveld 408576698