Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 91963002: Experimental scanner: End the octal position madness. (Closed)

Created:
7 years ago by marja
Modified:
7 years ago
Reviewers:
dcarney, ulan
CC:
v8-dev
Visibility:
Public.

Description

Experimental scanner: End the octal position madness. Now we just try to have the beginning of the octal position right, and are quite liberal about the end. It should be fine for all practical purposes. The error messages will change a bit. TBR=dcarney@chromium.org, ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18112

Patch Set 1 #

Patch Set 2 : work git cl work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
src/lexer/lexer-shell.cc View 3 chunks +6 lines, -11 lines 0 comments Download
src/lexer/lexer_py.re View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
marja
7 years ago (2013-11-27 16:07:59 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r18112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698