src/lexer/lexer_py.re - Issue 91963002: Experimental scanner: End the octal position madness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lexer/lexer_py.re

Issue 91963002: Experimental scanner: End the octal position madness. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser

Patch Set: work git cl work Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lexer/lexer_py.re

diff --git a/src/lexer/lexer_py.re b/src/lexer/lexer_py.re

index df03fe7c758da990205bcd7ca61e11882da946a8..7b0cababf8e029f6b1530fb3957efe6bf815593a 100644

--- a/src/lexer/lexer_py.re

+++ b/src/lexer/lexer_py.re

@@ -198,11 +198,11 @@ eos <|terminate|>

default_action <do_token_and_go_forward(ILLEGAL)>

<<DoubleQuoteString>>

-"\\" line_terminator_sequence <||continue>

+"\\" line_terminator_sequence <set_has_escapes||continue>

/\\[x][:hex_digit:]{2}/ <set_has_escapes||continue>

/\\[u][:hex_digit:]{4}/ <set_has_escapes||continue>

/\\[1-7]/ <octal_inside_string||continue>

-/\\[0-7]{2,3}/ <octal_inside_string||continue>

+/\\[0-7][0-7]+/ <octal_inside_string||continue>

/\\[^xu1-7:line_terminator:]/ <set_has_escapes||continue>

"\\" <|token(ILLEGAL)|>

line_terminator <|token(ILLEGAL)|>

@@ -212,11 +212,11 @@ catch_all <||continue>

<<SingleQuoteString>>

# TODO subgraph for '\'