Source/web/tests/PinchViewportTest.cpp - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/PinchViewportTest.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/PinchViewportTest.cpp

diff --git a/Source/web/tests/PinchViewportTest.cpp b/Source/web/tests/PinchViewportTest.cpp

index c9f4e10fd04f787d25a29430a0ce1442f731e977..a6157eb65bee9bb884e0305455a1fd9ed421a9c0 100644

--- a/Source/web/tests/PinchViewportTest.cpp

+++ b/Source/web/tests/PinchViewportTest.cpp

@@ -1326,7 +1326,7 @@ TEST_F(PinchViewportTest, ResizePinchViewportStaysWithinOuterViewport)

EXPECT_EQ(0, pinchViewport.location().y());

}

-TEST_F(PinchViewportTest, ElementBoundsInRootViewSpaceAccountsForViewport)

+TEST_F(PinchViewportTest, ElementBoundsInViewportSpaceAccountsForViewport)

{

initializeWithAndroidSettings();

@@ -1345,7 +1345,7 @@ TEST_F(PinchViewportTest, ElementBoundsInRootViewSpaceAccountsForViewport)

pinchViewport.setScale(2);

pinchViewport.setLocation(scrollDelta);

- IntRect boundsInViewport = inputElement->boundsInRootViewSpace();

+ IntRect boundsInViewport = inputElement->boundsInViewportSpace();

EXPECT_POINT_EQ(IntPoint(bounds.location() - scrollDelta),

boundsInViewport.location());

« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | public/web/WebView.h » ('j') | no next file with comments »