Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1711)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | Source/web/tests/PinchViewportTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index d51616f9a4a3adf4f1052d651bfffbf93e3e6eec..bce3d37477b6c8f47f744221ab38bcd9f7aaf048 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -1589,7 +1589,7 @@ void WebViewImpl::popupClosed(PopupContainer* popupContainer)
registry->didRemoveEventHandler(document, EventHandlerRegistry::WheelEvent);
}
-PagePopup* WebViewImpl::openPagePopup(PagePopupClient* client, const IntRect& originBoundsInRootView)
+PagePopup* WebViewImpl::openPagePopup(PagePopupClient* client)
{
ASSERT(client);
if (hasOpenedPopup())
@@ -1599,7 +1599,7 @@ PagePopup* WebViewImpl::openPagePopup(PagePopupClient* client, const IntRect& or
WebWidget* popupWidget = m_client->createPopupMenu(WebPopupTypePage);
ASSERT(popupWidget);
m_pagePopup = toWebPagePopupImpl(popupWidget);
- if (!m_pagePopup->initialize(this, client, originBoundsInRootView)) {
+ if (!m_pagePopup->initialize(this, client)) {
m_pagePopup->closePopup();
m_pagePopup = nullptr;
}
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | Source/web/tests/PinchViewportTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698