Source/web/WebPagePopupImpl.h - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPagePopupImpl.h

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPagePopupImpl.h

diff --git a/Source/web/WebPagePopupImpl.h b/Source/web/WebPagePopupImpl.h

index a50667c39e0a31a7d86e6f3de0c7b6676a4dd8e6..afd24bca0a2b202ee638c1a7fd067167dcaa8d43 100644

--- a/Source/web/WebPagePopupImpl.h

+++ b/Source/web/WebPagePopupImpl.h

@@ -59,7 +59,7 @@ class WebPagePopupImpl final

public:

virtual ~WebPagePopupImpl();

- bool initialize(WebViewImpl*, PagePopupClient*, const IntRect& originBoundsInRootView);

+ bool initialize(WebViewImpl*, PagePopupClient*);

bool handleKeyEvent(const PlatformKeyboardEvent&);

void closePopup();

WebWidgetClient* widgetClient() const { return m_widgetClient; }

« no previous file with comments | « Source/web/WebElement.cpp ('k') | Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »