Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2928)

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/WebPopupMenuImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebPagePopupImpl.cpp
diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp
index fae8fef4e5d6f9ae4673b77e1101b2ac98fe2780..0442bef6d883d5e93ded1a72df254bb132d81f39 100644
--- a/Source/web/WebPagePopupImpl.cpp
+++ b/Source/web/WebPagePopupImpl.cpp
@@ -92,7 +92,7 @@ private:
m_popup->widgetClient()->setWindowRect(m_popup->m_windowRectInScreen);
}
- virtual IntRect rootViewToScreen(const IntRect& rect) const override
+ virtual IntRect viewportToScreen(const IntRect& rect) const override
{
IntRect rectInScreen(rect);
rectInScreen.move(m_popup->m_windowRectInScreen.x, m_popup->m_windowRectInScreen.y);
@@ -212,7 +212,7 @@ WebPagePopupImpl::~WebPagePopupImpl()
ASSERT(!m_page);
}
-bool WebPagePopupImpl::initialize(WebViewImpl* webView, PagePopupClient* popupClient, const IntRect&)
+bool WebPagePopupImpl::initialize(WebViewImpl* webView, PagePopupClient* popupClient)
{
ASSERT(webView);
ASSERT(popupClient);
« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/WebPopupMenuImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698