Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 919033003: Promote Web Notifications and the Push API to stable features. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
blink-reviews, johnme, Miguel Garcia, mlamouri (slow - plz ping)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Promote Web Notifications and the Push API to stable features. Both APIs have received three LGTMs in their Intent to Ship threads, so update the runtime feature statuses accordingly. Web Notifications for Service Workers: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Cr7_GRSd2zM Push API: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/UdGlL9PtBLo Because we need to disable support for older Android versions and for the Android WebView, this is part of a two-sided patch. [1] This patch. [2] https://codereview.chromium.org/914373003 BUG=432527, 350378, 90795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190149

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Peter Beverloo
o/
5 years, 10 months ago (2015-02-12 20:13:50 UTC) #2
Mike West
LGTM. \o/
5 years, 10 months ago (2015-02-12 21:12:01 UTC) #3
Michael van Ouwerkerk
lgtm
5 years, 10 months ago (2015-02-13 11:51:37 UTC) #4
Peter Beverloo
I'm going to put this on the commit queue right now, to make sure that ...
5 years, 10 months ago (2015-02-13 13:49:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919033003/40001
5 years, 10 months ago (2015-02-13 13:51:16 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 15:16:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190149

Powered by Google App Engine
This is Rietveld 408576698