Exceptions for Web Notifications and the Push API by default.

Exceptions for enabling Web Notifications and the Push API by default.

These features will be available on all versions of Windows, Mac, Linux and
Chrome OS, on Android since the JellyBean release, but not yet in WebView.
This was covered in the two intent to ships.

Web Notifications for Service Workers:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Cr7_GRSd2zM

Push API:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/UdGlL9PtBLo

This is patch of a two-sided patch, where the first enables the feature
by default on all platforms.

  [1] https://codereview.chromium.org/919033003/
  [2] This patch.

BUG=432527, 350378, 90795
Committed: https://crrev.com/d948e026b32a9d86e79bb5b19ab93efc45c1b6ad
Cr-Commit-Position: refs/heads/master@{#316601}

[Peter Beverloo, 2015-02-12 20:17:39]

peter@chromium.org changed reviewers:
+ avi@chromium.org, mvanouwerkerk@chromium.org, tedchoc@chromium.org,
torne@chromium.org

[Peter Beverloo, 2015-02-12 20:17:40]

+torne for android_webview/
+tedchoc for content/browser/android/
+avi for command line flag and content/ OWNERS
+mvanouwerkerk for push_messaging_browsertest.cc

Let's do it!

As noted in the description, this depends on
https://codereview.chromium.org/919033003/ for providing the Blink API for
toggling Push Messaging.

[Avi (use Gerrit), 2015-02-12 20:37:11]

As per our push to kill command-line flags, is there a planned timeline to
remove the flag you're adding here?

Code LGTM

[Peter Beverloo, 2015-02-12 20:41:07]

On 2015/02/12 20:37:11, Avi wrote:
> As per our push to kill command-line flags, is there a planned timeline to
> remove the flag you're adding here?
> 
> Code LGTM

That timeline would be defined by formal Android ICS deprecation (undergoing,
but tedious) and support for Notifications and Push in WebView
(crbug.com/434712).

thanks!

[Michael van Ouwerkerk, 2015-02-13 11:50:47]

These changes look good but I'll chase down one or two other places that need
updating.

https://codereview.chromium.org/914373003/diff/40001/android_webview/lib/main...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/914373003/diff/40001/android_webview/lib/main...
android_webview/lib/main/aw_main_delegate.cc:78: // Web Notification API is not
supported (https://crbug.com/434712)
I know this is documented in runtime_features.cc but for readability could you
please call out that this also disables the Push API? Alternatively, rename
kDisableNotifications to kDisableNotificationsAndPush.

https://codereview.chromium.org/914373003/diff/40001/chrome/browser/services/...
File chrome/browser/services/gcm/push_messaging_browsertest.cc (right):

https://codereview.chromium.org/914373003/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/push_messaging_browsertest.cc:712: // This test
should only be ran on Android ICS to confirm that the Push API
nit: 'only run' and 'available'

https://codereview.chromium.org/914373003/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/push_messaging_browsertest.cc:720: 
nit: delete empty line

https://codereview.chromium.org/914373003/diff/40001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/914373003/diff/40001/content/public/common/co...
content/public/common/content_switches.cc:194: // Disables the Web Notification
API.
And the Push API.

[Michael van Ouwerkerk, 2015-02-13 11:54:29]

Yeah I think either this patch or a followup has to fix the check for
experimental web platform features in
chrome/browser/services/gcm/push_messaging_service_impl.cc

[Peter Beverloo, 2015-02-13 12:21:48]

New patchsets have been uploaded after l-g-t-m from avi@chromium.org

[Peter Beverloo, 2015-02-13 12:22:39]

On 2015/02/13 11:54:29, Michael van Ouwerkerk wrote:
> Yeah I think either this patch or a followup has to fix the check for
> experimental web platform features in
> chrome/browser/services/gcm/push_messaging_service_impl.cc

All done. Please take a look. (And ignore the try-bots since the Blink patch
isn't in yet..)

[Peter Beverloo, 2015-02-13 12:22:52]

https://codereview.chromium.org/914373003/diff/40001/android_webview/lib/main...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/914373003/diff/40001/android_webview/lib/main...
android_webview/lib/main/aw_main_delegate.cc:78: // Web Notification API is not
supported (https://crbug.com/434712)
On 2015/02/13 11:50:47, Michael van Ouwerkerk wrote:
> I know this is documented in runtime_features.cc but for readability could you
> please call out that this also disables the Push API? Alternatively, rename
> kDisableNotifications to kDisableNotificationsAndPush.

Done.

https://codereview.chromium.org/914373003/diff/40001/chrome/browser/services/...
File chrome/browser/services/gcm/push_messaging_browsertest.cc (right):

https://codereview.chromium.org/914373003/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/push_messaging_browsertest.cc:712: // This test
should only be ran on Android ICS to confirm that the Push API
On 2015/02/13 11:50:47, Michael van Ouwerkerk wrote:
> nit: 'only run' and 'available'

Done.

https://codereview.chromium.org/914373003/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/push_messaging_browsertest.cc:720: 
On 2015/02/13 11:50:47, Michael van Ouwerkerk wrote:
> nit: delete empty line

Done.

https://codereview.chromium.org/914373003/diff/40001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/914373003/diff/40001/content/public/common/co...
content/public/common/content_switches.cc:194: // Disables the Web Notification
API.
On 2015/02/13 11:50:47, Michael van Ouwerkerk wrote:
> And the Push API.

Done.

[Michael van Ouwerkerk, 2015-02-13 12:33:12]

Nice. lgtm

[Peter Beverloo, 2015-02-13 13:43:49]

New patchsets have been uploaded after l-g-t-m from mvanouwerkerk@chromium.org

[Peter Beverloo, 2015-02-13 13:44:22]

peter@chromium.org changed reviewers:
+ miguelg@chromium.org, rmcilroy@chromium.org
- tedchoc@chromium.org

[Peter Beverloo, 2015-02-13 13:44:23]

+rmcilroy for base/android/ (per Miguel's offline comment)

[Miguel Garcia, 2015-02-13 14:08:09]

lgtm

[Torne, 2015-02-13 14:11:32]

android_webview LGTM

[rmcilroy, 2015-02-13 14:17:30]

On 2015/02/13 14:11:32, Torne wrote:
> android_webview LGTM

base/android LGTM, thanks!

[Ted C, 2015-02-13 18:09:02]

On 2015/02/13 14:17:30, rmcilroy wrote:
> On 2015/02/13 14:11:32, Torne wrote:
> > android_webview LGTM
> 
> base/android LGTM, thanks!

content/browser/android - lgtm

[Peter Beverloo, 2015-02-16 12:26:28]

New patchsets have been uploaded after l-g-t-m from
miguelg@chromium.org,torne@chromium.org,rmcilroy@chromium.org,tedchoc@chromiu...

[Peter Beverloo, 2015-02-16 14:22:48]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-02-16 14:23:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914373003/120001

[Peter Beverloo, 2015-02-16 15:57:15]

The CQ bit was unchecked by peter@chromium.org

[Peter Beverloo, 2015-02-17 14:09:05]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-02-17 14:09:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914373003/120001

[commit-bot: I haz the power, 2015-02-17 14:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-17 14:17:32]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[Peter Beverloo, 2015-02-17 14:27:04]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-02-17 14:27:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914373003/140001

[commit-bot: I haz the power, 2015-02-17 16:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-17 16:23:19]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[Peter Beverloo, 2015-02-17 16:46:24]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-02-17 16:47:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914373003/160001

[commit-bot: I haz the power, 2015-02-17 17:50:02]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-02-17 17:50:45]

Patchset 9 (id:??) landed as
https://crrev.com/d948e026b32a9d86e79bb5b19ab93efc45c1b6ad
Cr-Commit-Position: refs/heads/master@{#316601}