Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 918063002: [Mac] Rename ShellNSWindow to AppNSWindow. (Closed)

Created:
5 years, 10 months ago by jackhou1
Modified:
5 years, 10 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@nawc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Rename ShellNSWindow to AppNSWindow. Other platforms renamed their class names in r251542: https://codereview.chromium.org/166573005 BUG=344082 Committed: https://crrev.com/e6150837aa821737e17d611069d1fb9dbbb0fe54 Cr-Commit-Position: refs/heads/master@{#318000}

Patch Set 1 #

Patch Set 2 : Sync and rebase #

Total comments: 2

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jackhou1
5 years, 10 months ago (2015-02-25 05:12:37 UTC) #2
tapted
lgtm % nits cl description nit: say "rename" rather than "change" and "for mac" you ...
5 years, 10 months ago (2015-02-25 06:06:33 UTC) #3
jackhou1
https://codereview.chromium.org/918063002/diff/20001/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h (right): https://codereview.chromium.org/918063002/diff/20001/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h#newcode24 chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h:24: @class AppNSWindow; On 2015/02/25 06:06:33, tapted wrote: > nit: ...
5 years, 10 months ago (2015-02-25 06:10:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918063002/40001
5 years, 10 months ago (2015-02-25 06:12:00 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-25 07:20:35 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 07:21:45 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e6150837aa821737e17d611069d1fb9dbbb0fe54
Cr-Commit-Position: refs/heads/master@{#318000}

Powered by Google App Engine
This is Rietveld 408576698