:visited invalidation for remaining text-related properties.

:visited invalidation for remaining text-related properties.

Following up https://codereview.chromium.org/900443006

All text-related CSS properties which may have different :visited style
needs to be checked when deciding if we need a repaint.

Also added a missing check for window.testRunner in the testcase for color.

R=wangxianzhu@chromium.org
BUG=439812
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190066

[rune, 2015-02-11 22:29:37]

Text properties fixed for :visited paint invalidation. More to come in other CLs
(borders, backgrounds, outlines, column-rules).

[rune, 2015-02-12 00:09:39]

A test/ref rendering artifact on Win + Mac ...

[Xianzhu, 2015-02-12 00:46:02]

There seems a sub-pixel gap in the underline in the expected result. Perhaps
changing the text content and/or font size could workaround it. Might worth
filing a bug?

https://codereview.chromium.org/917973002/diff/1/LayoutTests/fast/history/vis...
File LayoutTests/fast/history/visited-link-hover-text-decoration-color.html
(right):

https://codereview.chromium.org/917973002/diff/1/LayoutTests/fast/history/vis...
LayoutTests/fast/history/visited-link-hover-text-decoration-color.html:4:
testRunner.keepWebHistory();
What's this for?

[rune, 2015-02-12 09:34:50]

On 2015/02/12 at 00:46:02, wangxianzhu wrote:
> There seems a sub-pixel gap in the underline in the expected result. Perhaps
changing the text content and/or font size could workaround it. Might worth
filing a bug?

There was a double space in the reference. I've triggered the Mac and Win bots
to see if that's the issue.

[rune, 2015-02-12 09:35:00]

https://codereview.chromium.org/917973002/diff/1/LayoutTests/fast/history/vis...
File LayoutTests/fast/history/visited-link-hover-text-decoration-color.html
(right):

https://codereview.chromium.org/917973002/diff/1/LayoutTests/fast/history/vis...
LayoutTests/fast/history/visited-link-hover-text-decoration-color.html:4:
testRunner.keepWebHistory();
On 2015/02/12 at 00:46:02, Xianzhu wrote:
> What's this for?

It's required to have :visited styles apply at all.

[rune, 2015-02-12 10:25:39]

On 2015/02/12 at 09:34:50, rune wrote:
> On 2015/02/12 at 00:46:02, wangxianzhu wrote:
> > There seems a sub-pixel gap in the underline in the expected result. Perhaps
changing the text content and/or font size could workaround it. Might worth
filing a bug?
> 
> There was a double space in the reference. I've triggered the Mac and Win bots
to see if that's the issue.

Seems to have done the trick. PTAL.

[Xianzhu, 2015-02-12 17:46:19]

lgtm.

[rune, 2015-02-12 17:49:13]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2015-02-12 17:50:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917973002/20001

[commit-bot: I haz the power, 2015-02-12 19:12:02]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190066