Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 900443006: Check visited color for visual diff. (Closed)

Created:
5 years, 10 months ago by rune
Modified:
5 years, 10 months ago
Reviewers:
Timothy Loh, Xianzhu
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check visited color for visual diff. The color which is actually used for painting needs to be checked when figuring out if we need to do a paint invalidation. We are checking both the color for :link and :visited so that the visited state is not exposed through repaint timing. This is a problem for other colors as well. If this approach is OK'ed, I'll go ahead and fix the other ones. BUG=439812 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189918

Patch Set 1 #

Patch Set 2 : Avoid privacy issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A LayoutTests/fast/history/visited-link-hover.html View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fast/history/visited-link-hover-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/style/LayoutStyle.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rune
PTAL
5 years, 10 months ago (2015-02-10 00:09:01 UTC) #2
Timothy Loh
On 2015/02/10 00:09:01, rune wrote: > PTAL Does this unintentionally expose visited link status (maybe ...
5 years, 10 months ago (2015-02-10 00:22:49 UTC) #3
rune
On 2015/02/10 00:22:49, Timothy Loh wrote: > On 2015/02/10 00:09:01, rune wrote: > > PTAL ...
5 years, 10 months ago (2015-02-10 10:14:58 UTC) #5
Xianzhu
lgtm
5 years, 10 months ago (2015-02-10 16:41:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900443006/20001
5 years, 10 months ago (2015-02-10 16:52:29 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 18:35:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189918

Powered by Google App Engine
This is Rietveld 408576698