chrome/browser/resources/md_settings/md_settings.html - Issue 917893004: Add a <cr-dropdown-menu> custom element to cr_elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_settings/md_settings.html

Issue 917893004: Add a <cr-dropdown-menu> custom element to cr_elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@paperdropdown

Patch Set: Add an assert for a missing menu class Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css » ('j') | ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_settings/md_settings.html

diff --git a/chrome/browser/resources/md_settings/md_settings.html b/chrome/browser/resources/md_settings/md_settings.html

index 0211effaabf3b3f766bd6803d2356c7abae6dd07..23f949ce13e0c4f9fdfaf30145f781eba83bb928 100644

--- a/chrome/browser/resources/md_settings/md_settings.html

+++ b/chrome/browser/resources/md_settings/md_settings.html

@@ -3,10 +3,13 @@

<head>

<title>Settings</title>

+ <link rel="import" href="chrome://resources/polymer/paper-button/paper-button.html">

+ <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">

+ <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">

<link rel="import"

href="chrome://resources/cr_elements/cr_toggle_button/cr_toggle_button.html">

<link rel="import"

- href="chrome://resources/polymer/paper-button/paper-button.html">

+ href="chrome://resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.html">

</head>

<body>

@@ -15,6 +18,16 @@

<paper-button id="manage-button" raised>Manage</paper-button>

<cr-toggle-button checked></cr-toggle-button>

+ <section>

+ <h2>cr-dropdown-menu</h2>

+ <cr-dropdown-menu style="width: 200px">

michaelpg 2015/02/20 22:54:44 style should be in md_settings.css

Jeremy Klein 2015/02/20 23:28:13 I'm adding md_settings.css in https://codereview.c

+ <core-menu class="menu">

+ <paper-item>Chrome</paper-item>

+ <paper-item>IE</paper-item>

+ <paper-item>Firefox</paper-item>

+ </core-menu>

+ </cr-dropdown-menu>

+ </section>

</div>

</body>

</html>