chrome/browser/resources/md_settings/md_settings.html - Issue 917893004: Add a <cr-dropdown-menu> custom element to cr_elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_settings/md_settings.html

Issue 917893004: Add a <cr-dropdown-menu> custom element to cr_elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@paperdropdown

Patch Set: Add an assert for a missing menu class Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css » ('j') | ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Settings</title>	5 <title>Settings</title>

	6 <link rel="import" href="chrome://resources/polymer/paper-button/paper-button. html">

	7 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html ">

	8 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">

6 <link rel="import"	9 <link rel="import"

7 href="chrome://resources/cr_elements/cr_toggle_button/cr_toggle_button.htm l">	10 href="chrome://resources/cr_elements/cr_toggle_button/cr_toggle_button.htm l">

8 <link rel="import"	11 <link rel="import"

9 href="chrome://resources/polymer/paper-button/paper-button.html">	12 href="chrome://resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.htm l">

10 </head>	13 </head>

11 <body>	14 <body>

12 <header>	15 <header>

13 <h1>Settings</h1>	16 <h1>Settings</h1>

14 </header>	17 </header>

15 <div class="main">	18 <div class="main">

16 <paper-button id="manage-button" raised>Manage</paper-button>	19 <paper-button id="manage-button" raised>Manage</paper-button>

17 <cr-toggle-button checked></cr-toggle-button>	20 <cr-toggle-button checked></cr-toggle-button>

	21 <section>

	22 <h2>cr-dropdown-menu</h2>

	23 <cr-dropdown-menu style="width: 200px">
	michaelpg 2015/02/20 22:54:44 style should be in md_settings.css style should be in md_settings.css Jeremy Klein 2015/02/20 23:28:13 I'm adding md_settings.css in https://codereview.c Show quoted text On 2015/02/20 22:54:44, michaelpg wrote: > style should be in md_settings.css I'm adding md_settings.css in https://codereview.chromium.org/939533002/ so if it's ok with you, I'll just move this in that CL since this seems likely to land first.
	24 <core-menu class="menu">

	25 <paper-item>Chrome</paper-item>

	26 <paper-item>IE</paper-item>

	27 <paper-item>Firefox</paper-item>

	28 </core-menu>

	29 </cr-dropdown-menu>

	30 </section>

18 </div>	31 </div>

19 </body>	32 </body>

20 </html>	33 </html>

OLD	NEW