content/browser/frame_host/frame_tree_node.cc - Issue 917793006: Resetting FrameTreeNode must remove child FrameTreeNodes from global map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 917793006: Resetting FrameTreeNode must remove child FrameTreeNodes from global map. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_tree.h ('K') | « content/browser/frame_host/frame_tree.cc ('k') | content/browser/frame_host/frame_tree_unittest.cc » ('j') | content/browser/frame_host/frame_tree_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/frame_tree_node.cc

diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc

index 6d654aaa9007b084411932f0176b241770ba63e4..ac3ec6d82e24de2effae7802cac1eea200ca00b3 100644

--- a/content/browser/frame_host/frame_tree_node.cc

+++ b/content/browser/frame_host/frame_tree_node.cc

@@ -43,6 +43,7 @@ FrameTreeNode::~FrameTreeNode() {

switches::kEnableBrowserSideNavigation)) {

navigator_->CancelNavigation(this);

}

+ frame_tree_->RemoveNodeFromMap(frame_tree_node_id_);

Charlie Reis 2015/02/12 17:12:43 Why not frame_tree->RemoveFrame(this)? I'm guessi

nasko 2015/02/12 23:21:08 Done.

}

bool FrameTreeNode::IsMainFrame() const {