Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: content/browser/frame_host/frame_tree.h

Issue 917793006: Resetting FrameTreeNode must remove child FrameTreeNodes from global map. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree.h
diff --git a/content/browser/frame_host/frame_tree.h b/content/browser/frame_host/frame_tree.h
index 5f0c7aad333650f8fe2549f45346bbc710d751f1..5ef3e84dd285061c7617278de367408ec6a94995 100644
--- a/content/browser/frame_host/frame_tree.h
+++ b/content/browser/frame_host/frame_tree.h
@@ -76,6 +76,10 @@ class CONTENT_EXPORT FrameTree {
const std::string& frame_name);
void RemoveFrame(FrameTreeNode* child);
+ // This method only removes the FrameTreeNode from the global map of ids
Charlie Reis 2015/02/12 17:12:43 It feels a bit odd to have a public method for mod
nasko 2015/02/12 23:21:08 Done.
+ // to objects.
+ void RemoveNodeFromMap(int64 frame_tree_node_id);
+
// This method walks the entire frame tree and creates a RenderFrameProxyHost
// for the given |site_instance| in each node except the |source| one --
// the source will have a RenderFrameHost. It assumes that no frame tree
« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree.cc » ('j') | content/browser/frame_host/frame_tree_node.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698