Issue 917793004: Recognize _apptest files as test files in PRESUBMIT.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 917793004: Recognize _apptest files as test files in PRESUBMIT.py. (Closed)

Created:
5 years, 10 months ago by viettrungluu

Modified:
5 years, 10 months ago

Reviewers:
msw

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Recognize _apptest files as test files in PRESUBMIT.py. Also remove _apitest, _kiftest, and _uitest, since we don't have any of those in our repo. (We still have a lone _browsertest file in //base and _pixeltest files in //cc.) R=msw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/24cd9f02ab8fb8982c986f982ff5cc7c31a384fc

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	PRESUBMIT.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

5 years, 10 months ago (2015-02-11 18:57:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
24cd9f02ab8fb8982c986f982ff5cc7c31a384fc (presubmit successful).