PRESUBMIT.py - Issue 917793004: Recognize _apptest files as test files in PRESUBMIT.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 917793004: Recognize _apptest files as test files in PRESUBMIT.py. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 1db9250aefeb93f9426b0e5a352cfb24ce4cee64..08fd544c8f72150f954e90138822c0408c90ce53 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -44,7 +44,7 @@ _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$'

_TEST_CODE_EXCLUDED_PATHS = (

r'.*[\\\/](fake_|test_|mock_).+%s' % _IMPLEMENTATION_EXTENSIONS,

r'.+_test_(base|support|util)%s' % _IMPLEMENTATION_EXTENSIONS,

+ r'.+_(app|browser|perf|pixel|unit)?test(_[a-z]+)?%s' %

_IMPLEMENTATION_EXTENSIONS,

r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS,

r'.*[\\\/](test|tool(s)?)[\\\/].*',

« no previous file with comments | « no previous file | no next file » | no next file with comments »