Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 917793003: Actual fix for braille translation initialization race. (Closed)

Created:
5 years, 10 months ago by Peter Lundblad
Modified:
5 years, 10 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Actual fix for braille translation initialization race. This revers https://codereview.chromium.org/905353002 and instead waits with initializing liblouis until the DOMContentLoaded event fires. This makes loading the nacl module reliable and also gets rid of the retry loop that was used before. TESTED=manual BUG=none R=dtseng@chromium.org Committed: https://crrev.com/96b1042a3e4b5220e02369f3f5598915a07bc999 Cr-Commit-Position: refs/heads/master@{#316195}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js View 2 chunks +7 lines, -15 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/liblouis.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Peter Lundblad
5 years, 10 months ago (2015-02-11 15:41:00 UTC) #1
David Tseng
lgtm
5 years, 10 months ago (2015-02-11 17:02:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917793003/1
5 years, 10 months ago (2015-02-12 12:53:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24245)
5 years, 10 months ago (2015-02-12 13:49:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917793003/20001
5 years, 10 months ago (2015-02-13 08:52:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 09:19:35 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 09:20:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96b1042a3e4b5220e02369f3f5598915a07bc999
Cr-Commit-Position: refs/heads/master@{#316195}

Powered by Google App Engine
This is Rietveld 408576698