Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 905353002: Quick fix for ChromeVox braille flakiness. (Closed)

Created:
5 years, 10 months ago by Peter Lundblad
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick fix for ChromeVox braille flakiness. The libluis wrapper depends on the load event to fier when the nacl component is loaded to initialize the braille translator. Somehow, this doesn't fire during startup unless a message is sent to the component which causes braille translation to not work at all, resulting in no braille output on the display at all. This is a minimal workaround intended for backporting to the M-41 branch while the real cause can be investigated and addressed. BUG=455889 R=dtseng@chromium.org Committed: https://crrev.com/25651009b2e8af7a9f484cba914c57352e571750 Cr-Commit-Position: refs/heads/master@{#315319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/braille/liblouis.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Lundblad
5 years, 10 months ago (2015-02-09 15:28:25 UTC) #1
Peter Lundblad
Feel free to run this through the CQ if you like it for shorter round-trip.
5 years, 10 months ago (2015-02-09 15:29:16 UTC) #2
dmazzoni
lgtm
5 years, 10 months ago (2015-02-09 16:08:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905353002/1
5 years, 10 months ago (2015-02-09 16:09:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 16:15:01 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 16:16:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25651009b2e8af7a9f484cba914c57352e571750
Cr-Commit-Position: refs/heads/master@{#315319}

Powered by Google App Engine
This is Rietveld 408576698