new classes: implement default constructors.

new classes: implement default constructors.

R=arv@chromium.org,rossberg@chromium.org
BUG=v8:3834
LOG=N

Committed: https://crrev.com/9b158fa79a510bd1fee2f663163d9116879cb33a
Cr-Commit-Position: refs/heads/master@{#26594}

[Dmitry Lomov (no reviews), 2015-02-11 14:00:02]

PTAL, starting platform ports

[arv (Not doing code reviews), 2015-02-11 14:53:49]

LGTM

https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.c...
src/ia32/full-codegen-ia32.cc:3108: if (expr->expression()->IsSuperReference())
{
This is dead code... see https://codereview.chromium.org/911223002/

https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.c...
src/ia32/full-codegen-ia32.cc:4084: 
remove empty line

https://codereview.chromium.org/917753002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/917753002/diff/1/src/parser.cc#newcode292
src/parser.cc:292: AssertIsConstruct(body, pos);
Can you rename this to CreateAssertIsConstruct or AddAssertIsConstruct?

https://codereview.chromium.org/917753002/diff/1/src/parser.cc#newcode3924
src/parser.cc:3924: body->Add(if_statement, zone());
Another option would be to call this CreateAssertIsConstruct and do the add in
the caller.

https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes...
File test/mjsunit/harmony/classes-experimental.js (right):

https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes...
test/mjsunit/harmony/classes-experimental.js:257: var f = Subclass2.bind({}, 3,
4);
var -> let

https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes...
test/mjsunit/harmony/classes-experimental.js:284: assertTrue(eua.__proto__ ===
ExtendedUint8Array.prototype);
assertSame or assertEquals

[Dmitry Lomov (no reviews), 2015-02-11 16:29:00]

New patchsets have been uploaded after l-g-t-m from arv@chromium.org

[Dmitry Lomov (no reviews), 2015-02-11 16:29:36]

Please take another look: comments addressed + ports done

https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.c...
src/ia32/full-codegen-ia32.cc:3108: if (expr->expression()->IsSuperReference())
{
On 2015/02/11 14:53:48, arv wrote:
> This is dead code... see https://codereview.chromium.org/911223002/

Will rebase

https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.c...
src/ia32/full-codegen-ia32.cc:4084: 
On 2015/02/11 14:53:48, arv wrote:
> remove empty line

Done.

https://codereview.chromium.org/917753002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/917753002/diff/1/src/parser.cc#newcode292
src/parser.cc:292: AssertIsConstruct(body, pos);
On 2015/02/11 14:53:49, arv wrote:
> Can you rename this to CreateAssertIsConstruct or AddAssertIsConstruct?

Done.

https://codereview.chromium.org/917753002/diff/1/src/parser.cc#newcode3924
src/parser.cc:3924: body->Add(if_statement, zone());
On 2015/02/11 14:53:49, arv wrote:
> Another option would be to call this CreateAssertIsConstruct and do the add in
> the caller.

I like Add because it skips on FLAG_experimental_classes, but that does not
matter too much. 
The semantics we need is always create and add, so keeping Add

https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes...
File test/mjsunit/harmony/classes-experimental.js (right):

https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes...
test/mjsunit/harmony/classes-experimental.js:257: var f = Subclass2.bind({}, 3,
4);
On 2015/02/11 14:53:49, arv wrote:
> var -> let

Done.

https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes...
test/mjsunit/harmony/classes-experimental.js:284: assertTrue(eua.__proto__ ===
ExtendedUint8Array.prototype);
On 2015/02/11 14:53:49, arv wrote:
> assertSame or assertEquals

Done.

[arv (Not doing code reviews), 2015-02-11 16:41:45]

Still LGTM

https://codereview.chromium.org/917753002/diff/40001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/917753002/diff/40001/src/x64/code-stubs-x64.c...
src/x64/code-stubs-x64.cc:939: __ decl(rcx);
How is this related to this CL?

[Dmitry Lomov (no reviews), 2015-02-11 16:49:35]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-02-11 16:49:57]

https://codereview.chromium.org/917753002/diff/40001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/917753002/diff/40001/src/x64/code-stubs-x64.c...
src/x64/code-stubs-x64.cc:939: __ decl(rcx);
On 2015/02/11 16:41:45, arv wrote:
> How is this related to this CL?

Not really, just a sanity fix.

[commit-bot: I haz the power, 2015-02-11 16:50:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917753002/40001

[commit-bot: I haz the power, 2015-02-11 17:22:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-11 17:23:10]

Patchset 3 (id:??) landed as
https://crrev.com/9b158fa79a510bd1fee2f663163d9116879cb33a
Cr-Commit-Position: refs/heads/master@{#26594}