src/runtime/runtime-classes.cc - Issue 917753002: new classes: implement default constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-classes.cc

Issue 917753002: new classes: implement default constructors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase to run try jobs Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-classes.cc

diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc

index 077c3d5abee68d05655f5f87a7d053d1864633a1..ea641d3faf781a7ed033bec80678dc667f5df617 100644

--- a/src/runtime/runtime-classes.cc

+++ b/src/runtime/runtime-classes.cc

@@ -414,7 +414,15 @@ RUNTIME_FUNCTION(Runtime_StoreKeyedToSuper_Sloppy) {

}

+RUNTIME_FUNCTION(RuntimeReference_DefaultConstructorCallSuper) {

+ UNREACHABLE();

+ return nullptr;

+// TODO(dslomov): deprecated, will remove when experimenal classes is default.

RUNTIME_FUNCTION(Runtime_DefaultConstructorSuperCall) {

+ CHECK(!FLAG_experimental_classes);

HandleScope scope(isolate);

DCHECK(args.length() == 0);