Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 917743004: Enable layout descriptor consistency checks in heap verification mode. (Closed)

Created:
5 years, 10 months ago by Igor Sheludko
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable layout descriptor consistency checks in heap verification mode. Committed: https://crrev.com/2e54397ca3dc1a9c228dbf386f6155808e250ab7 Cr-Commit-Position: refs/heads/master@{#26624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 10 months ago (2015-02-12 15:14:49 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-12 15:53:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917743004/1
5 years, 10 months ago (2015-02-12 15:54:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 16:40:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 16:40:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e54397ca3dc1a9c228dbf386f6155808e250ab7
Cr-Commit-Position: refs/heads/master@{#26624}

Powered by Google App Engine
This is Rietveld 408576698