src/objects-debug.cc - Issue 917743004: Enable layout descriptor consistency checks in heap verification mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 917743004: Enable layout descriptor consistency checks in heap verification mode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 4211bc5ca49a7131d54ecd7f0c689008ad47d561..f7bdeede63ad1be0ce86b0e609f0e1ba76763cdf 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -324,8 +324,9 @@ void Map::MapVerify() {

SLOW_DCHECK(transitions()->IsSortedNoDuplicates());

SLOW_DCHECK(transitions()->IsConsistentWithBackPointers(this));

}

- SLOW_DCHECK(!FLAG_unbox_double_fields ||

- layout_descriptor()->IsConsistentWithMap(this));

+ // TODO(ishell): turn it back to SLOW_DCHECK.

+ CHECK(!FLAG_unbox_double_fields ||

+ layout_descriptor()->IsConsistentWithMap(this));

}

« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »