[V8] Use Function.name for stack frames in v8::StackTrace

[V8] Use Function.name for stack frames in v8::StackTrace

If function.name property has string type then stack frame will contain it otherwise DebugName from shared function info.

BUG=17356
LOG=Y
R=yurys@chromium.org

Committed: https://crrev.com/54196b17c863ced336103f630f3201ebb2cb7d3f
Cr-Commit-Position: refs/heads/master@{#27025}

[kozy, 2015-02-11 13:58:47]

Yury, please take a look.

[aandrey, 2015-02-11 15:30:51]

aandrey@chromium.org changed reviewers:
+ aandrey@chromium.org, yangguo@google.com

[aandrey, 2015-02-11 15:30:52]

lgtm

[kozy, 2015-02-12 10:17:57]

Yang, please take a look.

[kozy, 2015-02-12 10:48:25]

kozyatinskiy@chromium.org changed reviewers:
+ yangguo@chromium.org
- yangguo@google.com

[Yang, 2015-02-12 14:25:36]

https://codereview.chromium.org/917743002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/917743002/diff/1/src/isolate.cc#newcode562
src/isolate.cc:562: JSObject::AddProperty(stack_frame, function_key_,
display_name, NONE);
Why are we storing this in a separate property, and not under the same
"functionName"? Do we need to preserve the information about where the name
string originates?

[kozy, 2015-02-12 14:46:13]

https://codereview.chromium.org/917743002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/917743002/diff/1/src/isolate.cc#newcode562
src/isolate.cc:562: JSObject::AddProperty(stack_frame, function_key_,
display_name, NONE);
On 2015/02/12 14:25:36, Yang wrote:
> Why are we storing this in a separate property, and not under the same
> "functionName"? Do we need to preserve the information about where the name
> string originates?

In output stack frame we store display name or function name in the same
"functionName" property. In function we try receiving display name from current
JS function instance and if there is no this property then we get DebugName from
SharedFunctionInfo. As I understand it, we can have a lot of JS function objects
with different display names from one shared function info with its name.

[kozy, 2015-03-05 13:44:25]

Function.name is configurable after [1].
Stack frame use this property after this CL.

PTAL!

[1] https://codereview.chromium.org/977003004

[yurys, 2015-03-05 14:12:56]

https://codereview.chromium.org/917743002/diff/20001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/917743002/diff/20001/src/isolate.cc#newcode557
src/isolate.cc:557: if (fun_name.is_null() || !fun_name->IsString())
Can it ever be null?

https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc#...
test/cctest/test-api.cc:14928:
TEST(GetStackTraceContainsFunctionsWithDisplayName) {
...WithFunctionName

https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc#...
test/cctest/test-api.cc:14948:
v8::V8::AddMessageListener(StackTraceDisplayNameListener);
...DisplayName... -> ...FunctionName... here and below

[kozy, 2015-03-05 15:01:09]

ptal

https://codereview.chromium.org/917743002/diff/20001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/917743002/diff/20001/src/isolate.cc#newcode557
src/isolate.cc:557: if (fun_name.is_null() || !fun_name->IsString())
On 2015/03/05 14:12:56, yurys wrote:
> Can it ever be null?

Replaced with GetDataProperty

https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc#...
test/cctest/test-api.cc:14928:
TEST(GetStackTraceContainsFunctionsWithDisplayName) {
On 2015/03/05 14:12:56, yurys wrote:
> ...WithFunctionName

Done.

https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc#...
test/cctest/test-api.cc:14948:
v8::V8::AddMessageListener(StackTraceDisplayNameListener);
On 2015/03/05 14:12:56, yurys wrote:
> ...DisplayName... -> ...FunctionName... here and below

Done.

[kozy, 2015-03-05 15:01:10]

ptal

[yurys, 2015-03-05 15:13:54]

lgtm

[kozy, 2015-03-05 15:28:48]

Yang, please take a look.

[Yang, 2015-03-05 15:35:14]

On 2015/03/05 15:28:48, kozyatinskiy wrote:
> Yang, please take a look.

Lgtm.

[kozy, 2015-03-05 18:30:03]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2015-03-05 18:30:04]

The patchset sent to the CQ was uploaded after l-g-t-m from aandrey@chromium.org
Link to the patchset: https://codereview.chromium.org/917743002/#ps40001 (title:
"Added Function.name getter check")

[commit-bot: I haz the power, 2015-03-05 18:30:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917743002/40001

[commit-bot: I haz the power, 2015-03-05 18:31:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-05 18:31:58]

Patchset 3 (id:??) landed as
https://crrev.com/54196b17c863ced336103f630f3201ebb2cb7d3f
Cr-Commit-Position: refs/heads/master@{#27025}