Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Issue 977003004: ES6: Make function name configurable (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6: Make function name configurable Function name property is now standardized in ES6. It was a Mozilla proprietary extension before. With ES6, the property was made configurable, so that it can be used instead of another proprietary property, displayName. This is a revert of revert https://chromium.googlesource.com/v8/v8.git/+/c791d8411225aa95518c880defd9a5b1ea243afc. Last time this broke a Chrome browser test which has since been updated: https://chromium.googlesource.com/chromium/src/+/5f75a3be4c9334aba627d6c5eb884adf965e1d78 BUG=v8:3333 LOG=N R=mstarzinger@chromium.org,verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/f6cd009efd7a032907b11265e74102b0d45207a1 Cr-Commit-Position: refs/heads/master@{#26996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -21 lines) Patch
M src/accessors.cc View 1 chunk +34 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +19 lines, -15 lines 0 comments Download
A test/mjsunit/es6/function-name-configurable.js View 1 chunk +115 lines, -0 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 2 chunks +27 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1530.js View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-270142.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
PTAL There is no change to this CL from last time. Since last time I ...
5 years, 9 months ago (2015-03-04 10:24:24 UTC) #1
arv (Not doing code reviews)
Ping. This passes on the blink and chrome bots. It is ready to go.
5 years, 9 months ago (2015-03-04 12:35:54 UTC) #2
Toon Verwaest
lgtm
5 years, 9 months ago (2015-03-04 16:02:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977003004/1
5 years, 9 months ago (2015-03-04 16:26:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 16:57:01 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 16:57:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6cd009efd7a032907b11265e74102b0d45207a1
Cr-Commit-Position: refs/heads/master@{#26996}

Powered by Google App Engine
This is Rietveld 408576698