Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 917653002: Catch graceful failures when deserializing in d8. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Catch graceful failures when deserializing in d8. R=vogelheim@chromium.org Committed: https://crrev.com/505b6020a86378df98df4356d4ae8db182ef9dda Cr-Commit-Position: refs/heads/master@{#26579}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : correctly rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/d8.cc View 1 2 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Yang
5 years, 10 months ago (2015-02-11 09:52:18 UTC) #1
vogelheim
lgtm
5 years, 10 months ago (2015-02-11 11:32:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917653002/1
5 years, 10 months ago (2015-02-11 11:33:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2776)
5 years, 10 months ago (2015-02-11 11:34:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917653002/20001
5 years, 10 months ago (2015-02-11 12:35:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/2831)
5 years, 10 months ago (2015-02-11 12:37:46 UTC) #11
Yang
correctly rebase
5 years, 10 months ago (2015-02-11 13:31:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917653002/40001
5 years, 10 months ago (2015-02-11 13:32:35 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-11 14:10:08 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 14:10:17 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/505b6020a86378df98df4356d4ae8db182ef9dda
Cr-Commit-Position: refs/heads/master@{#26579}

Powered by Google App Engine
This is Rietveld 408576698