Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: src/d8.cc

Issue 917653002: Catch graceful failures when deserializing in d8. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: correctly rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 41b5fa75fbb3d0bbfe971d54c26359d62ee5a60a..246c17fae4815db05505eaac748eb13cb123eb1d 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -249,10 +249,13 @@ Local<Script> Shell::CompileString(
DCHECK(false); // A new compile option?
}
if (data == NULL) compile_options = ScriptCompiler::kNoCompileOptions;
- return source_type == SCRIPT
- ? ScriptCompiler::Compile(isolate, &cached_source, compile_options)
- : ScriptCompiler::CompileModule(isolate, &cached_source,
- compile_options);
+ Local<Script> result =
+ source_type == SCRIPT
+ ? ScriptCompiler::Compile(isolate, &cached_source, compile_options)
+ : ScriptCompiler::CompileModule(isolate, &cached_source,
+ compile_options);
+ CHECK(data == NULL || !data->rejected);
+ return result;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698