Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1574)

Issue 917643002: Copy the corresponding opt_count_and_bailout_reason info when invoking Runtime_SetCode. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Copy the corresponding opt_count_and_bailout_reason info when invoking Runtime_SetCode. This error is exposed by this CL: https://codereview.chromium.org/817293005. This CL set all Buildin JS function to optimization_disabled. And set the bailout reason to "kBuiltinFunctionCannotBeOptimized". But in Runtime_SetCode() function. It copied the the compiler_hints which include the "bool optimization_disabled" value, But the corresponding Bailout reason is not copied. This leads to the check error in "CompilationInfo::AbortOptimization(...)" function. This issue is exposed on turbofan unsupported X87 platform. Crankshaft is invoked to compile the typed array function Uint8Array. BUG= Committed: https://crrev.com/464f76b734d59b8c0f6cae1ee6e630360e97fa31 Cr-Commit-Position: refs/heads/master@{#26595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/runtime/runtime-function.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
chunyang.dai
Hello, Michael. PTAL. thanks
5 years, 10 months ago (2015-02-11 11:42:29 UTC) #2
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-11 16:01:35 UTC) #3
chunyang.dai
hello. Michael. It seems the trybot result is "exception on tryserver.v8". Could you help to ...
5 years, 10 months ago (2015-02-11 16:41:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917643002/1
5 years, 10 months ago (2015-02-11 17:02:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 17:32:05 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 17:32:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/464f76b734d59b8c0f6cae1ee6e630360e97fa31
Cr-Commit-Position: refs/heads/master@{#26595}

Powered by Google App Engine
This is Rietveld 408576698