Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 817293005: Avoid unintentional optimization of hot builtins by TurboFan. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid unintentional optimization of hot builtins by TurboFan. R=titzer@chromium.org TEST=mjsunit/regress/regress-crbug-451016 BUG=chromium:451016 LOG=N Committed: https://crrev.com/d2e424afb8dab8f1d9cc90512df9289c5dffc4c2 Cr-Commit-Position: refs/heads/master@{#26229}

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-451016.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 11 months ago (2015-01-22 15:02:56 UTC) #1
titzer
lgtm
5 years, 11 months ago (2015-01-22 18:33:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817293005/20001
5 years, 11 months ago (2015-01-22 18:50:54 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 18:52:09 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 18:52:24 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2e424afb8dab8f1d9cc90512df9289c5dffc4c2
Cr-Commit-Position: refs/heads/master@{#26229}

Powered by Google App Engine
This is Rietveld 408576698