Answers in Suggest icon downloading

chrome/browser/ui/views/omnibox/omnibox_result_view.h

Index: chrome/browser/ui/views/omnibox/omnibox_result_view.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.h b/chrome/browser/ui/views/omnibox/omnibox_result_view.h
index 4ce5c993b479b5f75f10e3a0526c12e4f9688cae..787eaf357663a51e4a2429644f744f05d0981f81 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.h
@@ -8,6 +8,7 @@
 #include <vector>
 
 #include "base/gtest_prod_util.h"
+#include "chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h"
 #include "components/omnibox/autocomplete_match.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/animation/animation_delegate.h"
@@ -75,6 +76,12 @@ class OmniboxResultView : public views::View,
   // Returns the display width required for the match contents.
   int GetMatchContentsWidth() const;
 
+  void SetAnswerImage(gfx::ImageSkia image);

[Peter Kasting, 2015/03/03 01:32:37]

Nit: Write a comment about what this does

[dschuyler, 2015/03/03 21:13:57]

Done.

+
+  base::WeakPtr<OmniboxResultView> GetWeakPtr() {

[Peter Kasting, 2015/03/03 01:32:37]

You shouldn't inline functions that aren't simple cheap accessors, and you
shouldn't name inlined functions in CamelCase.

In this case this doesn't even need to be exposed as a function -- the lone
caller could just call weak_ptr_factory_.GetWeakPtr() directly.

[dschuyler, 2015/03/03 21:13:57]

Done.

+    return weak_ptr_factory_.GetWeakPtr();
+  }
+
  protected:
   // Paints the given |match| using the RenderText instances |contents| and
   // |description| at offset |x| in the bounds of this view.
@@ -121,6 +128,7 @@ class OmniboxResultView : public views::View,
   // views::View:
   const char* GetClassName() const override;
 
+  void GetAnswerIcon();
   gfx::ImageSkia GetIcon() const;
   const gfx::ImageSkia* GetKeywordIcon() const;
 
@@ -153,6 +161,12 @@ class OmniboxResultView : public views::View,
 
   static int default_icon_size_;
 
+  // If the answer has an icon, these control the fetching and updating

[Peter Kasting, 2015/03/03 01:32:37]

Nit: Since the |image_service_| is initted unconditionally, it probably belongs
somewhere around where |location_bar_view_| is listed (since that's a similar
"raw pointer to a useful external object").  The other two I might put near the
bottom of the member list (maybe above the mutables?) since unlike most of the
other members they're only going to be occasionally relevant.

[dschuyler, 2015/03/03 21:13:57]

Done.

+  // of the icon.
+  BitmapFetcherService* image_service_;
+  BitmapFetcherService::RequestId request_id_;
+  gfx::ImageSkia answer_image_;
+
   // Default values cached here, may be overridden using the setters above.
   int edge_item_padding_;
   int item_padding_;
@@ -191,6 +205,8 @@ class OmniboxResultView : public views::View,
 
   mutable int separator_width_;
 
+  base::WeakPtrFactory<OmniboxResultView> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(OmniboxResultView);
 };