Answers in Suggest icon downloading

chrome/browser/ui/views/omnibox/omnibox_result_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
+#include "chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h"
 #include "components/omnibox/autocomplete_match.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/gfx/animation/slide_animation.h"
 #include "ui/gfx/font_list.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/view.h"
 
 class LocationBarView;
@@ skipping 47 matching lines @@
 
   ResultViewState GetState() const;
 
   // Returns the height of the text portion of the result view. In the base
   // class, this is the height of one line of text.
   virtual int GetTextHeight() const;
 
   // Returns the display width required for the match contents.
   int GetMatchContentsWidth() const;
 
+  void SetAnswerImage(gfx::ImageSkia image);

[Peter Kasting, 2015/03/03 01:32:37]

Nit: Write a comment about what this does

[dschuyler, 2015/03/03 21:13:57]

Done.

+
+  base::WeakPtr<OmniboxResultView> GetWeakPtr() {

[Peter Kasting, 2015/03/03 01:32:37]

You shouldn't inline functions that aren't simple cheap accessors, and you
shouldn't name inlined functions in CamelCase.

In this case this doesn't even need to be exposed as a function -- the lone
caller could just call weak_ptr_factory_.GetWeakPtr() directly.

[dschuyler, 2015/03/03 21:13:57]

Done.

+    return weak_ptr_factory_.GetWeakPtr();
+  }
+
  protected:
   // Paints the given |match| using the RenderText instances |contents| and
   // |description| at offset |x| in the bounds of this view.
   virtual void PaintMatch(const AutocompleteMatch& match,
                           gfx::RenderText* contents,
                           gfx::RenderText* description,
                           gfx::Canvas* canvas,
                           int x) const;
 
   // Draws given |render_text| on |canvas| at given location (|x|, |y|).
@@ skipping 26 matching lines @@
   void set_edge_item_padding(int value) { edge_item_padding_ = value; }
   void set_item_padding(int value) { item_padding_ = value; }
   void set_minimum_text_vertical_padding(int value) {
     minimum_text_vertical_padding_ = value;
   }
 
  private:
   // views::View:
   const char* GetClassName() const override;
 
+  void GetAnswerIcon();
   gfx::ImageSkia GetIcon() const;
   const gfx::ImageSkia* GetKeywordIcon() const;
 
   // Whether to render only the keyword match.  Returns true if |match_| has an
   // associated keyword match that has been animated so close to the start that
   // the keyword match will hide even the icon of the regular match.
   bool ShowOnlyKeywordMatch() const;
 
   // Resets all RenderTexts for contents and description of the |match_| and its
   // associated keyword match.
@@ skipping 12 matching lines @@
 
   // Returns the offset at which the contents of the |match| should be displayed
   // within the text bounds. The directionality of UI and match contents is used
   // to determine the offset relative to the correct edge.
   int GetDisplayOffset(const AutocompleteMatch& match,
                        bool is_ui_rtl,
                        bool is_match_contents_rtl) const;
 
   static int default_icon_size_;
 
+  // If the answer has an icon, these control the fetching and updating

[Peter Kasting, 2015/03/03 01:32:37]

Nit: Since the |image_service_| is initted unconditionally, it probably belongs
somewhere around where |location_bar_view_| is listed (since that's a similar
"raw pointer to a useful external object").  The other two I might put near the
bottom of the member list (maybe above the mutables?) since unlike most of the
other members they're only going to be occasionally relevant.

[dschuyler, 2015/03/03 21:13:57]

Done.

+  // of the icon.
+  BitmapFetcherService* image_service_;
+  BitmapFetcherService::RequestId request_id_;
+  gfx::ImageSkia answer_image_;
+
   // Default values cached here, may be overridden using the setters above.
   int edge_item_padding_;
   int item_padding_;
   int minimum_text_vertical_padding_;
 
   // This row's model and model index.
   OmniboxPopupContentsView* model_;
   size_t model_index_;
 
   LocationBarView* location_bar_view_;
@@ skipping 18 matching lines @@
   // We preserve these RenderTexts so that we won't recreate them on every call
   // to GetMatchContentsWidth() or OnPaint().
   mutable scoped_ptr<gfx::RenderText> contents_rendertext_;
   mutable scoped_ptr<gfx::RenderText> description_rendertext_;
   mutable scoped_ptr<gfx::RenderText> separator_rendertext_;
   mutable scoped_ptr<gfx::RenderText> keyword_contents_rendertext_;
   mutable scoped_ptr<gfx::RenderText> keyword_description_rendertext_;
 
   mutable int separator_width_;
 
+  base::WeakPtrFactory<OmniboxResultView> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(OmniboxResultView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_