Add retry feature for push-to-trunk script.

Add retry feature for push-to-trunk script.

Make url accesses retry. Git retry requires some more analysis of git output first (follow up CL).

BUG=
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18174

[Michael Achenbach, 2013-11-27 17:14:52]

PTAL

[Jakob Kummerow, 2013-11-28 13:47:26]

LGTM with comments.

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
File tools/push-to-trunk/common_includes.py (right):

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:243: retry_on: A callback that takes the
result of the function and returns True
nit: 80col

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:246: wait_plan: A list of waiting delays
between retries in seconds. The maximum
nit: 80col

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:250: wait_plan = list(wait_plan or [])
I don't think the explicit list() conversion is needed.

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:251: # Sentinel for the first try.
s/first/last/! This is seriously misleading.

Here's a slight refactoring that doesn't need the sentinel:

wait_plan.reverse()
while True:
  try:
    result = cb()
  except Exception:
    got_exception = True
  if got_exception or retry_on(result):
    if not wait_plan:
      raise Exception("Retried too often. Giving up.")
    wait_time = wait_plan.pop()
    print "Waiting for %f seconds." % wait_time
    self._side_effect_handler.Sleep(wait_time)
    print "Retrying..."
  else:
    return result

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:286: wait_plan = wait_plan or [3, 10, 30]
I'd give the server much more time. Maybe [3, 60, 600].

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/test...
File tools/push-to-trunk/test_scripts.py (right):

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/test...
tools/push-to-trunk/test_scripts.py:272: def Wait(seconds):
I think you mean s/Wait/Sleep/.

[Michael Achenbach, 2013-11-28 14:28:17]

Done.

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
File tools/push-to-trunk/common_includes.py (right):

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:243: retry_on: A callback that takes the
result of the function and returns True
On 2013/11/28 13:47:27, Jakob wrote:
> nit: 80col

Done.

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:246: wait_plan: A list of waiting delays
between retries in seconds. The maximum
On 2013/11/28 13:47:27, Jakob wrote:
> nit: 80col

Done.

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:250: wait_plan = list(wait_plan or [])
On 2013/11/28 13:47:27, Jakob wrote:
> I don't think the explicit list() conversion is needed.

I'd rather keep it, since the method has side effects on the parameter. If
somebody ever saved a wait plan in a variable on the call side for reuse...

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:251: # Sentinel for the first try.
On 2013/11/28 13:47:27, Jakob wrote:
> s/first/last/! This is seriously misleading.
> 
> Here's a slight refactoring that doesn't need the sentinel:
> 
> wait_plan.reverse()
> while True:
>   try:
>     result = cb()
>   except Exception:
>     got_exception = True
>   if got_exception or retry_on(result):
>     if not wait_plan:
>       raise Exception("Retried too often. Giving up.")
>     wait_time = wait_plan.pop()
>     print "Waiting for %f seconds." % wait_time
>     self._side_effect_handler.Sleep(wait_time)
>     print "Retrying..."
>   else:
>     return result

I take it :) Just added an initialization of got_exception.

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:286: wait_plan = wait_plan or [3, 10, 30]
On 2013/11/28 13:47:27, Jakob wrote:
> I'd give the server much more time. Maybe [3, 60, 600].

Done.

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/test...
File tools/push-to-trunk/test_scripts.py (right):

https://codereview.chromium.org/91733003/diff/150001/tools/push-to-trunk/test...
tools/push-to-trunk/test_scripts.py:272: def Wait(seconds):
On 2013/11/28 13:47:27, Jakob wrote:
> I think you mean s/Wait/Sleep/.

Done.

[Michael Achenbach, 2013-12-02 09:53:36]

Committed patchset #4 manually as r18174.