tools/push-to-trunk/push_to_trunk.py - Issue 91733003: Add retry feature for push-to-trunk script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/push-to-trunk/push_to_trunk.py

Issue 91733003: Add retry feature for push-to-trunk script. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed review comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/push-to-trunk/push_to_trunk.py

diff --git a/tools/push-to-trunk/push_to_trunk.py b/tools/push-to-trunk/push_to_trunk.py

index d78aacbd2b6202170335fb8069fa9ea0858eddd9..cee871fc6e478c403ea6cc78d5ac9f8138e3e515 100755

--- a/tools/push-to-trunk/push_to_trunk.py

+++ b/tools/push-to-trunk/push_to_trunk.py

@@ -102,7 +102,9 @@ class PrepareChangeLog(Step):

if match:

cl_url = "https://codereview.chromium.org/%s/description" % match.group(1)

try:

- body = self.ReadURL(cl_url)

+ # Fetch from Rietveld but only retry once with one second delay since

+ # there might be many revisions.

+ body = self.ReadURL(cl_url, wait_plan=[1])

except urllib2.URLError:

pass

return body

« no previous file with comments | « tools/push-to-trunk/common_includes.py ('k') | tools/push-to-trunk/test_scripts.py » ('j') | no next file with comments »